linux-kernel - Re: [PATCH v3] rcutorture: Copy out ftrace into its own console file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEXW_YQFXpEaJ4EuLOcxwyUOR7XiNmP0ShMtC6bcjSe6h=SSgw@mail.gmail.com>
Date:   Wed, 16 Aug 2023 19:50:31 -0400
From:   Joel Fernandes <joel@...lfernandes.org>
To:     paulmck@...nel.org
Cc:     linux-kernel@...r.kernel.org,
        Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Shuah Khan <shuah@...nel.org>, Joel <agnel.joel@...il.com>,
        rcu@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3] rcutorture: Copy out ftrace into its own console file

On Wed, Aug 16, 2023 at 7:46 PM Paul E. McKenney <paulmck@...nel.org> wrote:
>
> On Wed, Aug 16, 2023 at 07:27:03PM -0400, Joel Fernandes wrote:
> > On Wed, Aug 16, 2023 at 6:57 PM Paul E. McKenney <paulmck@...nel.org> wrote:
> > >
> > > On Tue, Aug 15, 2023 at 07:09:49PM +0000, Joel Fernandes (Google) wrote:
> > > > When debugging, it can be difficult to quickly find the ftrace dump
> > > > within the console log, which in turn makes it difficult to process it
> > > > independent of the result of the console output.  This commit therefore
> > > > copies the contents of the buffers into its own file to make it easier
> > > > to locate and process the ftrace dump. The original ftrace dump is still
> > > > available in the console log in cases where it is more convenient to
> > > > process it there, for example, when you have a script that processes
> > > > console output as well as ftrace-dump data.
> > > >
> > > > Also handle the case of multiple ftrace dumps potentially showing up in the
> > > > log. Example for a file like [1], it will extract as [2].
> > > >
> > > > [1]:
> > > > foo
> > > > foo
> > > > Dumping ftrace buffer:
> > > > ---------------------------------
> > > > blah
> > > > blah
> > > > ---------------------------------
> > > > more
> > > > bar
> > > > baz
> > > > Dumping ftrace buffer:
> > > > ---------------------------------
> > > > blah2
> > > > blah2
> > > > ---------------------------------
> > > > bleh
> > > > bleh
> > > >
> > > > [2]:
> > > >
> > > > Ftrace dump 1:
> > > > blah
> > > > blah
> > > >
> > > > Ftrace dump 2:
> > > > blah2
> > > > blah2
> > > >
> > > >
> > > > Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
> > >
> > > Very good, and I did queue this one.
> > >
> > > I fixed the indentation of the awk script.  Perhaps your text editor is
> > > being too smart for our good?  ;-)
> >
> > Thanks!  Yes the editor messing up is a possibility, I'll go look at
> > that, though the indent seems still messed up in your dev branch:
> >
> > The line "/Dumping ftrace buffer:/ " has spaces, as does the "awk <
> > $1" line. Is that intentional?  All the following ones have tabs.
>
> Not intentional at all, thank you for catching it!
>
> How about the fixup patch shown below, to be merged into the current
> commit?

Looks good to me, thanks!

 - Joel



>
>                                                         Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit 2322b84997c61e98bd48369f12c9b83b6e0d0ffb
> Author: Paul E. McKenney <paulmck@...nel.org>
> Date:   Wed Aug 16 16:44:49 2023 -0700
>
>     fixup! rcutorture: Copy out ftrace into its own console file
>
>     Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
>
> diff --git a/tools/testing/selftests/rcutorture/bin/functions.sh b/tools/testing/selftests/rcutorture/bin/functions.sh
> index 1ac86f68a436..6e415ddb206f 100755
> --- a/tools/testing/selftests/rcutorture/bin/functions.sh
> +++ b/tools/testing/selftests/rcutorture/bin/functions.sh
> @@ -339,9 +339,9 @@ specify_qemu_net () {
>  # [...]
>  # ---------------------------------
>  extract_ftrace_from_console() {
> -        awk < "$1" '
> +       awk < "$1" '
>
> -        /Dumping ftrace buffer:/ {
> +       /Dumping ftrace buffer:/ {
>                 buffer_count++
>                 print "Ftrace dump " buffer_count ":"
>                 capture = 1