linux-kernel - Re: [PATCH] smb: client: fix null auth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5msYemdM+J_ETsrHOkxmm4qeDnA8cLYOHVA9LhfjoBnYuQ@mail.gmail.com>
Date:   Wed, 16 Aug 2023 00:28:36 -0500
From:   Steve French <smfrench@...il.com>
To:     Paulo Alcantara <pc@...guebit.com>
Cc:     Scott Mayhew <smayhew@...hat.com>,
        Steve French <sfrench@...ba.org>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Tom Talpey <tom@...pey.com>, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org,
        Steve French <stfrench@...rosoft.com>
Subject: Re: [PATCH] smb: client: fix null auth

Fixed some checkpatch warnings and added Paulo's RB, and updated
cifs-2.6.git for-next


On Tue, Aug 15, 2023 at 1:42 PM Paulo Alcantara via samba-technical
<samba-technical@...ts.samba.org> wrote:
>
> Scott Mayhew <smayhew@...hat.com> writes:
>
> > Commit abdb1742a312 removed code that clears ctx->username when
> > sec=none, so attempting to mount with '-o sec=none' now fails with
> > -EACCES.  Fix it by adding that logic to the parsing of the 'sec'
> > option, as well as checking if the mount is using null auth before
> > setting the username when parsing the 'user' option.
> >
> > Fixes: abdb1742a312 ("cifs: get rid of mount options string parsing")
> > Signed-off-by: Scott Mayhew <smayhew@...hat.com>
> > ---
> >  fs/smb/client/fs_context.c | 4 ++++
> >  1 file changed, 4 insertions(+)
>
> Reviewed-by: Paulo Alcantara (SUSE) <pc@...guebit.com>
>


-- 
Thanks,

Steve

View attachment "0001-smb-client-fix-null-auth.patch" of type "text/x-patch" (1603 bytes)