[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a77403f5-8b99-3012-3843-1999ee8d12ce@linaro.org>
Date: Wed, 16 Aug 2023 07:44:25 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Elson Roy Serrao <quic_eserrao@...cinc.com>,
gregkh@...uxfoundation.org, Thinh.Nguyen@...opsys.com,
rogerq@...nel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
devicetree@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: usb: snps,dwc3: Add
runtime-suspend-on-usb-suspend property
On 14/08/2023 20:50, Elson Roy Serrao wrote:
> This property allows dwc3 runtime suspend when bus suspend interrupt
> is received even with cable connected. This would allow the dwc3
> controller to enter low power mode during bus suspend scenario.
>
> This property would particularly benefit dwc3 IPs where hibernation is
> not enabled and the dwc3 low power mode entry/exit is handled by the
> glue driver. The assumption here is that the platform using this dt
> property is capable of detecting resume events to bring the controller
> out of suspend.
>
> Signed-off-by: Elson Roy Serrao <quic_eserrao@...cinc.com>
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index a696f23730d3..e19a60d06d2b 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -403,6 +403,11 @@ properties:
> description:
> Enable USB remote wakeup.
>
> + snps,runtime-suspend-on-usb-suspend:
> + description:
> + If True then dwc3 runtime suspend is allowed during bus suspend
> + case even with the USB cable connected.
This was no tested... but anyway, this is no a DT property but OS
policy. There is no such thing as "runtime suspend" in the hardware,
because you describe one particular OS.
Sorry, no a DT property, drop the change entirely.
Best regards,
Krzysztof
Powered by blists - more mailing lists