linux-kernel - Re: [PATCH] bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87111632-f032-87a4-159f-1dd5357bac70@linaro.org>
Date:   Wed, 16 Aug 2023 07:53:59 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Anvesh Jain P <quic_ajainp@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Satya Priya <quic_c_skakit@...cinc.com>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Venkata Rao Kakani <quic_vkakani@...cinc.com>
Subject: Re: [PATCH] bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx

On 01/08/2023 13:51, Anvesh Jain P wrote:
> Update rtc-pm8xxx bindings with disable-alarm-wakeup property.
> 
> Signed-off-by: Venkata Rao Kakani <quic_vkakani@...cinc.com>
> Signed-off-by: Anvesh Jain P <quic_ajainp@...cinc.com>
> ---
>  Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> index 9c51c1b19067..e4f1d2ff02b6 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> @@ -42,6 +42,9 @@ properties:
>  
>    interrupt-controller: true
>  
> +  disable-alarm-wakeup:
> +    description: optional, disable alarm wake up capability.

This was no tested. Missing type, vendor prefix. Additionally the
description says absolutely nothing, just repeats the schema.

Sorry, does not look like hardware property with such description.

Anyway sending it without DTS or driver is also no-go, so NAK, sorry.

Best regards,
Krzysztof