[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <169216755001.1947971.13071516719161593963.b4-ty@kernel.org>
Date: Wed, 16 Aug 2023 09:32:30 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Yishai Hadas <yishaih@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] RDMA/mlx4: Copy union directly
On Tue, 15 Aug 2023 14:39:53 -0600, Gustavo A. R. Silva wrote:
> Copy union directly instead of using memcpy().
>
> Note that in this case, a direct assignment is more readable and
> consistent with the subsequent assignments.
>
> This addresses the following -Wstringop-overflow warning seen in s390
> with defconfig:
> drivers/infiniband/hw/mlx4/main.c:296:33: warning: writing 16 bytes into a region of size 0 [-Wstringop-overflow=]
> 296 | memcpy(&port_gid_table->gids[free].gid,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 297 | &attr->gid, sizeof(attr->gid));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> [...]
Applied, thanks!
[1/1] RDMA/mlx4: Copy union directly
https://git.kernel.org/rdma/rdma/c/18ddaeb03bdb65
Best regards,
--
Leon Romanovsky <leon@...nel.org>
Powered by blists - more mailing lists