[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <CB5067F1-28CC-4011-A6FF-0695916D764C@geanix.com>
Date: Wed, 16 Aug 2023 09:22:48 +0200
From: Sean Nyekjaer <sean@...nix.com>
To: Alain Volmat <alain.volmat@...s.st.com>
Cc: Pierre-Yves MORDRET <pierre-yves.mordret@...s.st.com>,
Andi Shyti <andi.shyti@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
linux-i2c@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: stm32f7: Add atomic_xfer method to driver
Hi Alain,
> On 16 Aug 2023, at 09.02, Sean Nyekjaer <sean@...nix.com> wrote:
>
[ … ]
>>> _dev {
>>> u32 dnf_dt;
>>> u32 dnf;
>>> struct stm32f7_i2c_alert *alert;
>>> + bool atomic;
>>
>> I am wondering if this atomic really needs to be within the struct.
>> It could well be given as last arg of stm32f7_i2c_xfer_core and
>> stm32f7_i2c_xfer functions.
>
> Agree.
Scratch that…
The atomic was included in the struct because it’s also used in the isr function, as the isr function is calling stm32f7_i2c_xfer_msg()
/Sean
Powered by blists - more mailing lists