linux-kernel - Re: linux-next-2023-0815: s390/block/dasd: build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230816-substantiell-ansporn-5db2e3d0c877@brauner>
Date:   Wed, 16 Aug 2023 10:11:26 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
        linux-next@...r.kernel.org, linux-kbuild@...r.kernel.org,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-s390@...r.kernel.org, Stefan Haberland <sth@...ux.ibm.com>,
        Jan Hoeppner <hoeppner@...ux.ibm.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: linux-next-2023-0815: s390/block/dasd: build error

On Wed, Aug 16, 2023 at 05:14:39PM +1000, Stephen Rothwell wrote:
> Hi Randy,
> 
> On Tue, 15 Aug 2023 22:34:19 -0700 Randy Dunlap <rdunlap@...radead.org> wrote:
> >
> > I have spent some time on this but I don't see where the problem is.
> > 
> > ERROR: modpost: "bdev_mark_dead" [drivers/s390/block/dasd_mod.ko] undefined!
> > 
> > CONFIG_BLOCK=y, bdev.o is built and contains the missing symbol.
> > 
> > Full randconfig file is attached.
> > 
> > Hopefully I'm just overlooking something.
> 
> In your config, CONFIG_DASD=m which means "#ifdef CONFIG_DASD" will
> fail since CONFIG_DASD_MODULE is defined instead ... so maybe it should
> be "#if IS_ENABLED(CONFIG_DASD)" in block/bdev.c.  This also fails an
> s390 allmodconfig build (obviously).
> 
> So this is caused by commit
> 
>   381f678306ce ("block: consolidate __invalidate_device and fsync_bdev")
> 
> from the vfs-brauner branch in linux-next.

Thanks for reporting this everyone. Fixed in-tree.