[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <OS3P286MB259916DCE3D992135FF05F4CB115A@OS3P286MB2599.JPNP286.PROD.OUTLOOK.COM>
Date: Wed, 16 Aug 2023 16:38:19 +0800
From: Riwen Lu <luriwen@...mail.com>
To: jikos@...nel.org, benjamin.tissoires@...hat.com,
dmitry.torokhov@...il.com, linux@...ssschuh.net,
hdegoede@...hat.com, rrangel@...omium.org,
u.kleine-koenig@...gutronix.de
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
sergeantsagara@...tonmail.com, Riwen Lu <luriwen@...inos.cn>
Subject: [PATCH v2] HID: i2c-hid: use print_hex_dump_debug to print report descriptor
From: Riwen Lu <luriwen@...inos.cn>
The format '%*ph' print up to 64 bytes long as a hex string with ' '
sepatator. Usually the size of report descriptor is larger than 64
bytes, so consider using print_hex_dump_debug to print out all of it for
better debugging.
Signed-off-by: Riwen Lu <luriwen@...inos.cn>
---
v1->v2:
- Add a prefix for the hex dump.
---
drivers/hid/i2c-hid/i2c-hid-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index efbba0465eef..fd82e9042da5 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -772,7 +772,9 @@ static int i2c_hid_parse(struct hid_device *hid)
}
}
- i2c_hid_dbg(ihid, "Report Descriptor: %*ph\n", rsize, rdesc);
+ i2c_hid_dbg(ihid, "Report Descriptor\n");
+ print_hex_dump_debug("Report Descriptor: ", DUMP_PREFIX_OFFSET, 16, 1,
+ rdesc, rsize, false);
ret = hid_parse_report(hid, rdesc, rsize);
if (!use_override)
--
2.25.1
Powered by blists - more mailing lists