linux-kernel - Re: [PATCH] thermal: sun8i_thermal: remove unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87248920-c5d6-1ab7-db87-f0dc34b787ec@linaro.org>
Date:   Wed, 16 Aug 2023 12:32:44 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Andrei Coardos <aboutphysycs@...il.com>,
        linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org
Cc:     samuel@...lland.org, jernej.skrabec@...il.com, wens@...e.org,
        rui.zhang@...el.com, amitk@...nel.org, rafael@...nel.org,
        tiny.windzz@...il.com, anarsoul@...il.com, alex@...uggie.ro
Subject: Re: [PATCH] thermal: sun8i_thermal: remove unneeded call to
 platform_set_drvdata()

On 11/08/2023 21:40, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
> 
> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---

Applied, thanks

Are you checking neither dev_get_drvdata is used ?


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog