[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNywVhVe1H8S60FR@qmqm.qmqm.pl>
Date: Wed, 16 Aug 2023 13:17:42 +0200
From: Michał Mirosław <mirq-linux@...e.qmqm.pl>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Peter Xu <peterx@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Michał Mirosław <emmir@...gle.com>,
Andrei Vagin <avagin@...il.com>,
Paul Gofman <pgofman@...eweavers.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
Shuah Khan <shuah@...nel.org>,
Christian Brauner <brauner@...nel.org>,
Yang Shi <shy828301@...il.com>,
Vlastimil Babka <vbabka@...e.cz>,
"Liam R . Howlett" <Liam.Howlett@...cle.com>,
Yun Zhou <yun.zhou@...driver.com>,
Suren Baghdasaryan <surenb@...gle.com>,
Alex Sierra <alex.sierra@....com>,
Matthew Wilcox <willy@...radead.org>,
Pasha Tatashin <pasha.tatashin@...een.com>,
Axel Rasmussen <axelrasmussen@...gle.com>,
"Gustavo A . R . Silva" <gustavoars@...nel.org>,
Dan Williams <dan.j.williams@...el.com>,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
Greg KH <gregkh@...uxfoundation.org>, kernel@...labora.com,
Cyrill Gorcunov <gorcunov@...il.com>,
Mike Rapoport <rppt@...nel.org>, Nadav Amit <namit@...are.com>,
David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH v31 2/6] fs/proc/task_mmu: Implement IOCTL to get and
optionally clear info about PTEs
On Wed, Aug 16, 2023 at 03:38:10PM +0500, Muhammad Usama Anjum wrote:
> The PAGEMAP_SCAN IOCTL on the pagemap file can be used to get or optionally
> clear the info about page table entries.
[...]
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
[...]
> +static long do_pagemap_scan(struct mm_struct *mm, unsigned long uarg)
> +{
[...]
> + for (walk_start = p.arg.start; walk_start < p.arg.end;
> + walk_start = p.arg.walk_end) {
[...]
> + /* The walk_end isn't set when ret is zero */
> + if (!p.arg.walk_end)
> + p.arg.walk_end = p.arg.end;
This is now redundant with the `if` after the loop. [1]
> + if (ret != -ENOSPC)
> + break;
> +
> + if (p.arg.vec_len == 0 || p.found_pages == p.arg.max_pages)
> + break;
> + }
> +
> + /* ENOSPC signifies early stop (buffer full) from the walk. */
> + if (!ret || ret == -ENOSPC)
> + ret = n_ranges_out;
> +
> + if (!p.arg.walk_end)
> + p.arg.walk_end = p.arg.end;
[1] The one above.
Best Regards
Michał Mirosław
Powered by blists - more mailing lists