linux-kernel - Re: [patch V4 00/41] x86/cpu: Rework the topology evaluation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Aug 2023 11:36:59 +0000
From:   "Zhang, Rui" <rui.zhang@...el.com>
To:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>,
        "Gross, Jurgen" <jgross@...e.com>,
        "mikelley@...rosoft.com" <mikelley@...rosoft.com>,
        "arjan@...ux.intel.com" <arjan@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        "ray.huang@....com" <ray.huang@....com>,
        "andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
        "Sivanich, Dimitri" <dimitri.sivanich@....com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "puwen@...on.cn" <puwen@...on.cn>
Subject: Re: [patch V4 00/41] x86/cpu: Rework the topology evaluation

On Mon, 2023-08-14 at 10:53 +0200, Thomas Gleixner wrote:
> Hi!
> 
> This is the follow up to V3:
> 
>   https://lore.kernel.org/lkml/20230802101635.459108805@linutronix.de
> 
> which addresses the review feedback.
> 
> TLDR:
> 
> This reworks the way how topology information is evaluated via CPUID
> in preparation for a larger topology management overhaul to address
> shortcomings of the current code vs. hybrid systems and systems which
> make
> use of the extended topology domains in leaf 0x1f. Aside of that it's
> an
> overdue spring cleaning to get rid of accumulated layers of duct tape
> and
> haywire.
> 
> What changed vs. V3:
> 
>   - Added the Hygon fix from Pu Wen and adjusted the new code
> accordingly
> 
>   - Fixed the off by one in the AMD parser for real - Michael
> 
>   - Reworked the unknown domain type handling in the 0xb/01f parser -
> Rui
> 
>   - Made core ID package relative - Rui
> 
>   - Folded the missing u32 conversions - Qiuxu
> 
>   - Folded the fake_topology() fixup from the full topology series
> 
>   - Small cleanups and enhancements
> 
>   - Picked up Tested-by tags
> 
> The series is based on the the APIC cleanup series in tip:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/apic
> 
> and also available on top of that from git:
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git topo-
> cpuid-v4
> 
> 
Although there is still discussion ongoing, I tested this patch series
on two different platforms with Module Type enumerated, and the lscpu
output as well as the topology sysfs look good, so

Tested-by: Zhang Rui <rui.zhang@...el.com>

thanks,
rui