linux-kernel - Re: [PATCH 3/6] sched: Extract __schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230816122007.W7OJW3Fx@linutronix.de>
Date:   Wed, 16 Aug 2023 14:20:07 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Phil Auld <pauld@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, bsegall@...gle.com,
        boqun.feng@...il.com, swood@...hat.com, bristot@...hat.com,
        dietmar.eggemann@....com, mingo@...hat.com, jstultz@...gle.com,
        juri.lelli@...hat.com, mgorman@...e.de, rostedt@...dmis.org,
        vschneid@...hat.com, vincent.guittot@...aro.org,
        longman@...hat.com, will@...nel.org
Subject: Re: [PATCH 3/6] sched: Extract __schedule_loop()

On 2023-08-16 07:39:45 [-0400], Phil Auld wrote:
> I do.  Admittedly I'm not an expert in how the wchan unwinding works but
> we have a slightly older version of this patch in our kernel (schedule_loop
> not __schedule_loop). When I added __sched it fixed it.   Maybe there
> is something else but that seemed pretty obvious. 
> 
> 
> /* Attach to any functions which should be ignored in wchan output. */
> #define __sched		__section(".sched.text")
> 
> I can't explain why you are not seeing it.

as peterz pointed out, it is marked __always_inline so the compiler
shouldn't make a separate function out of it.
Could you check with _this_ series? The schedule_loop variant is in RT
and does not have this inline thingy. So it would be good if the issue
you report actually exists in the series that has been posted.

> Cheers,
> Phil

Sebastian