linux-kernel - RE: [EXT] Re: [PATCH v1 net] octeontx2-pf: fix page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR1801MB191841FB6F596F753B72534FD315A@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date:   Wed, 16 Aug 2023 02:14:37 +0000
From:   Ratheesh Kannoth <rkannoth@...vell.com>
To:     Jesper Dangaard Brouer <hawk@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.cm" <pabeni@...hat.cm>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "aleksander.lobakin@...el.com" <aleksander.lobakin@...el.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>
Subject: RE: [EXT] Re: [PATCH v1 net] octeontx2-pf: fix page_pool creation
 fail for rings > 32k

> From: Jesper Dangaard Brouer <hawk@...nel.org>
> Sent: Tuesday, August 15, 2023 2:12 PM
> To: Ratheesh Kannoth <rkannoth@...vell.com>; netdev@...r.kernel.org;
> Subject: [EXT] Re: [PATCH v1 net] octeontx2-pf: fix page_pool creation fail
> for rings > 32k
> 
>   These pages are pinned down over time as working sets varies, due to
>   the recycling nature of page pool, given page pool (currently) don't
>   have a shrinker mechanism, the pages remain pinned down in ptr_ring.

ACK

> 
> > As page pool does direct
> > recycling way more aggressivelyi, often times ptr_ring is left
>                                   ^
> Typo
> (my suggestion already covers recycling)
ACK, will remove this line.

> > unused at all. Instead of clamping page_pool size to 32k at most,
> > limit it even more to 2k to avoid wasting memory on much less used
> > ptr_ring.
> 
> I would adjust and delete "much less used".
ACK

> And then produce a statement in the commit desc like:
> 
>   This have been tested on octeontx2 hardware (devel board xyz).
>   TCP and UDP tests using netperf shows not performance regressions.
Let me do more testing and get back.