linux-kernel - Re: [PATCH] riscv: suspend: Add syscore ops for suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230816-mural-portion-5b22d90e83fd@wendy>
Date:   Wed, 16 Aug 2023 13:33:30 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Nick Hu <nick.hu@...ive.com>
CC:     <paul.walmsley@...ive.com>, <palmer@...belt.com>,
        <aou@...s.berkeley.edu>, <ajones@...tanamicro.com>,
        <mason.huo@...rfivetech.com>, <jeeheng.sia@...rfivetech.com>,
        <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Andy Chiu <andy.chiu@...ive.com>
Subject: Re: [PATCH] riscv: suspend: Add syscore ops for suspend

On Wed, Aug 16, 2023 at 11:40:09AM +0800, Nick Hu wrote:
> Save and restore the FPU and vector states when system suspend. If a
> task is the one who performs the suspend flow and it also do some
> floating or vector operations before the suspend, we should save and
> restore the FPU states and vector states for this task.
> 
> Signed-off-by: Nick Hu <nick.hu@...ive.com>

> Signed-off-by: Andy Chiu <andy.chiu@...ive.com>

What was Andy's contribution to the patch?
Are you missing a co-developed-by tag?

Also, I'm a bit confused by the commit message due to a lack of
knowledge here - is this a fix or a new feature?
It reads as if things are not being saved/restored correctly, but
there's no "fix" related keywords in the commit message nor a Fixes:
tag.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)