linux-kernel - Re: [PATCH] rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <500a73ea-98e9-4b85-a34f-88a7bd98550d@app.fastmail.com>
Date:   Wed, 16 Aug 2023 15:10:19 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        "Alessandro Zummo" <a.zummo@...ertech.it>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        "Maxime Coquelin" <mcoquelin.stm32@...il.com>,
        "Alexandre Torgue" <alexandre.torgue@...s.st.com>,
        "Valentin Caron" <valentin.caron@...s.st.com>
Cc:     linux-rtc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM_OPS()

On Wed, Aug 16, 2023, at 13:33, Geert Uytterhoeven wrote:
> If CONFIG_PM_SLEEP=n (e.g. m68k/allmodconfig):
>
>     drivers/rtc/rtc-stm32.c:904:12: error: ‘stm32_rtc_resume’ defined 
> but not used [-Werror=unused-function]
>       904 | static int stm32_rtc_resume(struct device *dev)
> 	  |            ^~~~~~~~~~~~~~~~
>     drivers/rtc/rtc-stm32.c:894:12: error: ‘stm32_rtc_suspend’ defined 
> but not used [-Werror=unused-function]
>       894 | static int stm32_rtc_suspend(struct device *dev)
> 	  |            ^~~~~~~~~~~~~~~~~
>
> Indeed, the previous change mixed up the semantics between
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and NOIRQ_SYSTEM_SLEEP_PM_OPS().
> Fix this by using the modern NOIRQ_SYSTEM_SLEEP_PM_OPS() instead.
>
> Reported-by: noreply@...erman.id.au
> Fixes: a69c610e13e2b2de ("rtc: stm32: remove incorrect #ifdef check")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Reviewed-by: Arnd Bergmann <arnd@...db.de>