[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpq1o3VRMTgWb-uFf7qTQ897ishiJ9HTNWcxHgLyyfpAOg@mail.gmail.com>
Date: Wed, 16 Aug 2023 16:14:22 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>
Cc: Dikshita Agarwal <quic_dikshita@...cinc.com>,
Randy Dunlap <rdunlap@...radead.org>,
Vikash Garodia <quic_vgarodia@...cinc.com>,
stanimir.k.varbanov@...il.com, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org, mchehab@...nel.org,
hans.verkuil@...co.com, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 01/33] MAINTAINERS: Add Qualcomm Iris video accelerator driver
Hello,
On Wed, 16 Aug 2023 at 15:00, Bryan O'Donoghue
<bryan.odonoghue@...aro.org> wrote:
>
> On 14/08/2023 19:44, Dikshita Agarwal wrote:
> >
> >
> > On 7/29/2023 4:18 AM, Randy Dunlap wrote:
> >>
> >>
> >> On 7/28/23 06:23, Vikash Garodia wrote:
> >>> Add an entry for Iris video encoder/decoder accelerator driver.
> >>>
> >>> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
> >>> Signed-off-by: Vikash Garodia <quic_vgarodia@...cinc.com>
> >>> ---
> >>> MAINTAINERS | 10 ++++++++++
> >>> 1 file changed, 10 insertions(+)
> >>>
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index 3be1bdf..ea633b2 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -17671,6 +17671,16 @@ T: git git://linuxtv.org/media_tree.git
> >>> F: Documentation/devicetree/bindings/media/*venus*
> >>> F: drivers/media/platform/qcom/venus/
> >>>
> >>> +QUALCOMM IRIS VIDEO ACCELERATOR DRIVER
> >>
> >> This entry should immediately follow:
> >> QUALCOMM IPQ4019 VQMMC REGULATOR DRIVER
> >>
> >> to keep the file in alphabetical order.
> >>
> > Sure, will fix this in next version.
>
> I think TBH before we see a next version, there needs to be a conclusive
> argument on why a new driver - instead of an update to the existing
> venus - is the way to go.
>
> We have an ongoing corpus of working code that people use. The attempt
> to at least _try_ to integrate 8550 and beyond to upstream venus should
> be made.
>
> If it fails, then we can discuss a branched driver.
>
> Its not up to me but, that's certainly my honest and unvarnished input.
>
> Instead of investing time in V2 - please invest time in upstream venus
> or make the technical argument conclusively _prior_ to V2 as to why V2
> and beyond is the "only" way forward for 8550 and beyond.
I'd second this request. At the very least (as I wrote in response to
another email), consider reworking venus into core and interface
specific parts and making iris3 use a common base layer.
We already have drivers which work across multiple platforms, taking
care of differences. Few to name: GPU, display, sound, DSP, camss.
--
With best wishes
Dmitry
Powered by blists - more mailing lists