linux-kernel - Re: [PATCH net-next] net: fec: use napi_consume_skb() in fec_enet_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230816143334.GZ22185@unreal>
Date:   Wed, 16 Aug 2023 17:33:34 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Wei Fang <wei.fang@....com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, alexander.duyck@...il.com,
        xiaoning.wang@....com, shenwei.wang@....com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH net-next] net: fec: use napi_consume_skb() in
 fec_enet_tx_queue()

On Wed, Aug 16, 2023 at 05:02:42PM +0800, Wei Fang wrote:
> Now that the "budget" is passed into fec_enet_tx_queue(), one
> optimization we can do is to use napi_consume_skb() to instead
> of dev_kfree_skb_any().
> 
> Signed-off-by: Wei Fang <wei.fang@....com>
> Suggested-by: Alexander H Duyck <alexander.duyck@...il.com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>