linux-kernel - Re: [PATCH v1] drivers: usb: Replaces spaces with tabs for indentation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230816024632.GA57274@atom0118>
Date:   Wed, 16 Aug 2023 08:16:32 +0530
From:   Atul Kumar Pant <atulpant.linux@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     stern@...land.harvard.edu, bagasdotme@...il.com, raychi@...gle.com,
        f.suligoi@...m.it, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v1] drivers: usb: Replaces spaces with tabs for
 indentation.

On Tue, Aug 15, 2023 at 11:08:02PM +0200, Greg KH wrote:
> On Wed, Aug 16, 2023 at 02:14:39AM +0530, Atul Kumar Pant wrote:
> > This patch fixes following checkpatch.pl issue:
> > ERROR: code indent should use tabs where possible
> > 
> > Signed-off-by: Atul Kumar Pant <atulpant.linux@...il.com>
> > ---
> >  drivers/usb/core/hub.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> You didn't mention "hub" in the subject?
> 
> Again, please start out by doing work in drivers/staging/ to learn how
> to write good patches, before venturing out into other areas of the
> kernel.  Fixing up whitespace issues in random kernel parts is not
> always encouraged.

	Sure Greg, I'll check /drivers/staging/ and will avoid doing whitespace
	changes in random kernel parts.

> 
> thanks,
> 
> greg k-h