linux-kernel - RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR12MB50882D093C2880097F90778BD315A@DM4PR12MB5088.namprd12.prod.outlook.com>
Date:   Wed, 16 Aug 2023 15:45:08 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Rohan G Thomas <rohan.g.thomas@...el.com>
CC:     "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Jose Abreu <Jose.Abreu@...opsys.com>
Subject: RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback

From: Rohan G Thomas <rohan.g.thomas@...el.com>
Date: Tue, Aug 15, 2023 at 04:51:45

> From: Rohan G Thomas <rohan.g.thomas@...el.com>
> Date: Mon, Aug 14, 2023 at 15:06:37
> > > > +	bool tx_q_coe_lmt;
> > >
> > > Please use a flag here instead of "tx_q_coe_lmt". This is the
> > > preferrable method now.
> > >
> > > Thanks,
> > > Jose
> > 
> > Thanks Jose for the feedback. If I read that correctly, your suggestion is to
> > change " tx_q_coe_lmt" to something more readable, like "has_txcoe_limit".
> > Please correct me if I understand it wrongly.
> > 
> > BR,
> > Rohan
> >
> 
> Or, use int instead of bool?

No, I mean to replace it with a bit flag as it was done on https://lore.kernel.org/all/20230710090001.303225-1-brgl@bgdev.pl/.

Thanks,
Jose