linux-kernel - Re: [PATCH 10/17] zorro: include zorro.h in names.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWuFSX+W6-MaiUAf+s4pqmGZnX2z5NV1vyGVQaMz5CaWw@mail.gmail.com>
Date:   Wed, 16 Aug 2023 17:49:46 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        linux-m68k@...ts.linux-m68k.org
Subject: Re: [PATCH 10/17] zorro: include zorro.h in names.c

On Thu, Aug 10, 2023 at 4:22 PM Arnd Bergmann <arnd@...nel.org> wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The zorro_name_device() function is defined in drivers/zorror/names.c, but
> the declaration is not visible there:
>
> drivers/zorro/names.c:58:13: error: no previous prototype for 'zorro_name_device' [-Werror=missing-prototypes]
>    58 | void __init zorro_name_device(struct zorro_dev *dev)
>
> Include the header to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
i.e. will queue in the m68k for-v6.6 branch, with the "zorror" typo fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds