[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230817094529.68ae1083@kernel.org>
Date: Thu, 17 Aug 2023 09:45:29 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Martin Hundebøll <martin@...nix.com>
Cc: Wolfgang Grandegger <wg@...ndegger.com>,
Marc Kleine-Budde <mkl@...gutronix.de>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Chandrasekar Ramakrishnan <rcsekar@...sung.com>,
linux-can@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] can: netlink: support setting hardware filters
On Thu, 17 Aug 2023 12:10:13 +0200 Martin Hundebøll wrote:
> + int len = nla_len(data[IFLA_CAN_HW_FILTER]);
> + int num_filter = len / sizeof(struct can_filter);
> + struct can_filter *filter = nla_data(data[IFLA_CAN_HW_FILTER]);
This will prevent you from ever extending struct can_filter in
a backward-compatible fashion, right? I obviously know very little
about CAN but are you confident a more bespoke API to manipulate
filters individually and allow extensibility is not warranted?
Powered by blists - more mailing lists