linux-kernel - Re: [PATCH -next] ACPI: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Aug 2023 19:53:11 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     rafael@...nel.org, lenb@...nel.org, robert.moore@...el.com,
        hdegoede@...hat.com, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        acpica-devel@...ts.linuxfoundation.org
Subject: Re: [PATCH -next] ACPI: Remove unused declarations

On Mon, Aug 14, 2023 at 3:56 PM Yue Haibing <yuehaibing@...wei.com> wrote:
>
> acpi_create_dir()/acpi_remove_dir() are never implemented since
> the beginning of git history.
> Commit f8d31489629c ("ACPICA: Debugger: Convert some mechanisms to OSPM specific")
> declared but never implemented acpi_run_debugger().
> Commit 781d737c7466 ("ACPI: Drop power resources driver")
> removed acpi_power_init() but not its declaration.
>
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  drivers/acpi/internal.h | 1 -
>  include/acpi/acpi_bus.h | 2 --
>  include/acpi/acpixf.h   | 2 --
>  3 files changed, 5 deletions(-)
>
> diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
> index 5f5c3a159872..866c7c4ed233 100644
> --- a/drivers/acpi/internal.h
> +++ b/drivers/acpi/internal.h
> @@ -123,7 +123,6 @@ int __acpi_device_uevent_modalias(const struct acpi_device *adev,
>  /* --------------------------------------------------------------------------
>                                    Power Resource
>     -------------------------------------------------------------------------- */
> -int acpi_power_init(void);
>  void acpi_power_resources_list_free(struct list_head *list);
>  int acpi_extract_power_resources(union acpi_object *package, unsigned int start,
>                                  struct list_head *list);
> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
> index 23fbe4a16972..18203ee9096d 100644
> --- a/include/acpi/acpi_bus.h
> +++ b/include/acpi/acpi_bus.h
> @@ -569,8 +569,6 @@ int acpi_match_device_ids(struct acpi_device *device,
>                           const struct acpi_device_id *ids);
>  void acpi_set_modalias(struct acpi_device *adev, const char *default_id,
>                        char *modalias, size_t len);
> -int acpi_create_dir(struct acpi_device *);
> -void acpi_remove_dir(struct acpi_device *);
>
>  static inline bool acpi_device_enumerated(struct acpi_device *adev)
>  {
> diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
> index 0c1b69ad95d0..3d90716f9522 100644
> --- a/include/acpi/acpixf.h
> +++ b/include/acpi/acpixf.h
> @@ -970,8 +970,6 @@ ACPI_EXTERNAL_RETURN_STATUS(acpi_status
>                                                void **data,
>                                                void (*callback)(void *)))
>
> -void acpi_run_debugger(char *batch_buffer);
> -
>  void acpi_set_debugger_thread_id(acpi_thread_id thread_id);
>
>  #endif                         /* __ACXFACE_H__ */
> --

Applied (under edited subject) as 6.6 material, thanks!