[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230817-ppc_xmon-v1-1-8cc2d51b9995@google.com>
Date: Thu, 17 Aug 2023 11:11:56 -0700
From: ndesaulniers@...gle.com
To: Michael Ellerman <mpe@...erman.id.au>,
Nicholas Piggin <npiggin@...il.com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Nathan Chancellor <nathan@...nel.org>,
Tom Rix <trix@...hat.com>
Cc: Joel Stanley <joel@....id.au>, linuxppc-dev@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
Nick Desaulniers <ndesaulniers@...gle.com>
Subject: [PATCH] Revert "powerpc/xmon: Relax frame size for clang"
This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa.
I have not been able to reproduce the reported -Wframe-larger-than=
warning (or disassembly) with clang-11 or clang-18.
I don't know precisely when this was fixed in llvm, but it may be time
to revert this.
Closes: https://github.com/ClangBuiltLinux/linux/issues/252
Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
---
arch/powerpc/xmon/Makefile | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile
index d334de392e6c..7705aa74a24d 100644
--- a/arch/powerpc/xmon/Makefile
+++ b/arch/powerpc/xmon/Makefile
@@ -10,12 +10,6 @@ KCSAN_SANITIZE := n
# Disable ftrace for the entire directory
ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE)
-ifdef CONFIG_CC_IS_CLANG
-# clang stores addresses on the stack causing the frame size to blow
-# out. See https://github.com/ClangBuiltLinux/linux/issues/252
-KBUILD_CFLAGS += -Wframe-larger-than=4096
-endif
-
ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC)
obj-y += xmon.o nonstdio.o spr_access.o xmon_bpts.o
---
base-commit: 16931859a6500d360b90aeacab3b505a3560a3ed
change-id: 20230817-ppc_xmon-d288d803610e
Best regards,
--
Nick Desaulniers <ndesaulniers@...gle.com>
Powered by blists - more mailing lists