lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Fri, 18 Aug 2023 04:32:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kashyap Desai <kashyap.desai@...adcom.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Leon Romanovsky <leon@...nel.org>,
        Selvin Xavier <selvin.xavier@...adcom.com>
Subject: drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:279: warning: Function
 parameter or member 'rcfw' not described in '__poll_for_resp'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   16931859a6500d360b90aeacab3b505a3560a3ed
commit: 354f5bd985af9515190828bc642ebdf59acea121 RDMA/bnxt_re: add helper function __poll_for_resp
date:   10 weeks ago
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230818/202308180401.iaj2ktTc-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230818/202308180401.iaj2ktTc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308180401.iaj2ktTc-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:73: warning: Function parameter or member 'opcode' not described in 'bnxt_qplib_map_rc'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:105: warning: Function parameter or member 'rcfw' not described in '__wait_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:105: warning: Function parameter or member 'cookie' not described in '__wait_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:105: warning: Function parameter or member 'opcode' not described in '__wait_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:147: warning: Function parameter or member 'rcfw' not described in '__block_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:147: warning: Function parameter or member 'cookie' not described in '__block_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:147: warning: Function parameter or member 'opcode' not described in '__block_for_resp'
>> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:279: warning: Function parameter or member 'rcfw' not described in '__poll_for_resp'
>> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:279: warning: Function parameter or member 'cookie' not described in '__poll_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:279: warning: Function parameter or member 'opcode' not described in '__poll_for_resp'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:348: warning: Function parameter or member 'rcfw' not described in '__bnxt_qplib_rcfw_send_message'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:348: warning: Function parameter or member 'msg' not described in '__bnxt_qplib_rcfw_send_message'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:418: warning: Function parameter or member 'rcfw' not described in 'bnxt_qplib_rcfw_send_message'
   drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:418: warning: Function parameter or member 'msg' not described in 'bnxt_qplib_rcfw_send_message'


vim +279 drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

   262	
   263	/**
   264	 * __poll_for_resp   -	self poll completion for rcfw command
   265	 * @rcfw      -   rcfw channel instance of rdev
   266	 * @cookie    -   cookie to track the command
   267	 * @opcode    -   rcfw submitted for given opcode
   268	 *
   269	 * It works same as __wait_for_resp except this function will
   270	 * do self polling in sort interval since interrupt is disabled.
   271	 * This function can not be called from non-sleepable context.
   272	 *
   273	 * Returns:
   274	 * -ETIMEOUT if command is not completed in specific time interval.
   275	 * 0 if command is completed by firmware.
   276	 */
   277	static int __poll_for_resp(struct bnxt_qplib_rcfw *rcfw, u16 cookie,
   278				   u8 opcode)
 > 279	{
   280		struct bnxt_qplib_cmdq_ctx *cmdq = &rcfw->cmdq;
   281		unsigned long issue_time;
   282		u16 cbit;
   283	
   284		cbit = cookie % rcfw->cmdq_depth;
   285		issue_time = jiffies;
   286	
   287		do {
   288			if (test_bit(ERR_DEVICE_DETACHED, &cmdq->flags))
   289				return bnxt_qplib_map_rc(opcode);
   290	
   291			usleep_range(1000, 1001);
   292	
   293			bnxt_qplib_service_creq(&rcfw->creq.creq_tasklet);
   294			if (!test_bit(cbit, cmdq->cmdq_bitmap))
   295				return 0;
   296			if (jiffies_to_msecs(jiffies - issue_time) > 10000)
   297				return -ETIMEDOUT;
   298		} while (true);
   299	};
   300	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ