linux-kernel - Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43796724-4926-c7e0-9532-92b863550780@tuxon.dev>
Date:   Thu, 17 Aug 2023 08:31:48 +0300
From:   claudiu beznea <claudiu.beznea@...on.dev>
To:     Mihai.Sain@...rochip.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        Nicolas.Ferre@...rochip.com, Cristian.Birsan@...rochip.com,
        alexandre.belloni@...tlin.com, andre.przywara@....com,
        Jerry.Ray@...rochip.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Andrei.Simion@...rochip.com,
        Varshini Rajendran <varshini.rajendran@...rochip.com>
Subject: Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for
 sama5d29_curiosity board



On 8/16/23 12:05, Mihai.Sain@...rochip.com wrote:
> Hi Claudiu,
> 
> ----------------------
> 
> Hi, Mihai,
> 
> On 8/10/23 09:47, Mihai.Sain@...rochip.com wrote:
>>> +&i2s0 {
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2s0_default>;
>>> +     status = "okay";
>> I see no sound bindings on DT. Is there any reason for having this here?
>> # i2s0 bus is wired to RPi 40-pin connector. I want to have this node and its pinctrl here.
>> # i2c1, flx4-spi, pwm0, uart1 are also wired to Rpi connector, and are defined here.
>> # The same logic we apply also for mikroBUS sockets: i2c, pwm, spi and uart nodes are defined here.
>>
> 
> Can you use it (either with user space tools or other kernel consumers) w/o additional device tree bindings?
> # Yes. We have added in dt-overlay the codec which uses the i2s0 and i2c1 nodes and pinctrls.

overlay means additional DT bindings to me. So, I suggest to move the i2s
node there, too. It is the same approach that you've taken for ethernet node.