[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ad30a8ed-87d3-46dd-8b34-83f6cfac0e4a@linaro.org>
Date: Thu, 17 Aug 2023 23:24:23 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Kees Cook <keescook@...omium.org>, Andy Gross <agross@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
Georgi Djakov <djakov@...nel.org>,
linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] interconnect: qcom: Annotate struct icc_onecell_data with
__counted_by
On 17.08.2023 22:42, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct icc_onecell_data.
> Additionally, since the element count member must be set before accessing
> the annotated flexible array member, move its initialization earlier.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Andy Gross <agross@...nel.org>
> Cc: Bjorn Andersson <andersson@...nel.org>
> Cc: Konrad Dybcio <konrad.dybcio@...aro.org>
> Cc: Georgi Djakov <djakov@...nel.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
Very nice, thanks
Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
Konrad
Powered by blists - more mailing lists