linux-kernel - Re: [PATCH v8 2/5] iommu: Add new iommu op to get iommu hardware information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Aug 2023 14:55:27 -0700
From:   Nicolin Chen <nicolinc@...dia.com>
To:     "Tian, Kevin" <kevin.tian@...el.com>
CC:     "Liu, Yi L" <yi.l.liu@...el.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "jgg@...dia.com" <jgg@...dia.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>,
        "cohuck@...hat.com" <cohuck@...hat.com>,
        "eric.auger@...hat.com" <eric.auger@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "mjrosato@...ux.ibm.com" <mjrosato@...ux.ibm.com>,
        "chao.p.peng@...ux.intel.com" <chao.p.peng@...ux.intel.com>,
        "yi.y.sun@...ux.intel.com" <yi.y.sun@...ux.intel.com>,
        "peterx@...hat.com" <peterx@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "shameerali.kolothum.thodi@...wei.com" 
        <shameerali.kolothum.thodi@...wei.com>,
        "lulu@...hat.com" <lulu@...hat.com>,
        "suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@...el.com>
Subject: Re: [PATCH v8 2/5] iommu: Add new iommu op to get iommu hardware
 information

On Thu, Aug 17, 2023 at 07:24:44AM +0000, Tian, Kevin wrote:
> 
> > From: Liu, Yi L <yi.l.liu@...el.com>
> > Sent: Wednesday, August 16, 2023 8:14 PM
> >
> > Different IOMMU hardware would have different hardware information. So
> > the
> > information reported differs as well. To let the external user understand
> > the difference. enum iommu_hw_info_type is defined. For the iommu
> 
> s/difference. enum/difference, enum/
> 
> > + * @hw_info: IOMMU hardware information. The type of the returned data
> > is
> > + *           marked by the output type of this op. Type is one of
> > + *           enum iommu_hw_info_type defined in
> > include/uapi/linux/iommufd.h.
> > + *           The drivers that support this op should define a unique type
> > + *           in include/uapi/linux/iommufd.h. The data buffer returned by this
> > + *           op is allocated in the IOMMU driver and the caller should free it
> > + *           after use. Return the data buffer if success, or ERR_PTR on
> > + *           failure.
> 
> simplified as:
> 
>  @hw_info: report iommu hardware information. The data buffer returned by
>            this op is allocated in the iommu driver and freed by the caller
>            after use. The information type is one of enum iommu_hw_info_type
>            defined in include/uapi/linux/iommufd.h.
> 
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>

Done. Thanks!