linux-kernel - Re: [PATCH] kunit: fix struct kunit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOS=d1cZoJWOEZ95_X1ozEBa6X7O91UyZTDmTtajtewD+dg@mail.gmail.com>
Date:   Fri, 18 Aug 2023 06:14:17 +0800
From:   David Gow <davidgow@...gle.com>
To:     Rae Moar <rmoar@...gle.com>
Cc:     shuah@...nel.org, brendan.higgins@...ux.dev,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] kunit: fix struct kunit_attr header

On Fri, 18 Aug 2023 at 03:15, Rae Moar <rmoar@...gle.com> wrote:
>
> Add parameter descriptions to struct kunit_attr header for the
> parameters attr_default and print.
>
> Fixes: 39e92cb1e4a1 ("kunit: Add test attributes API structure")
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308180127.VD7YRPGa-lkp@intel.com/
>
> Signed-off-by: Rae Moar <rmoar@...gle.com>
> ---

LGTM, Thanks.

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

>  lib/kunit/attributes.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/kunit/attributes.c b/lib/kunit/attributes.c
> index 5e3034b6be99..1b512f7e1838 100644
> --- a/lib/kunit/attributes.c
> +++ b/lib/kunit/attributes.c
> @@ -30,6 +30,8 @@ enum print_ops {
>   * attribute value
>   * @filter: function to indicate whether a given attribute value passes a
>   * filter
> + * @attr_default: default attribute value used during filtering
> + * @print: value of enum print_ops to indicate when to print attribute
>   */
>  struct kunit_attr {
>         const char *name;
>
> base-commit: 582eb3aeed2d06b122fba95518b84506d3d4ceb9
> --
> 2.42.0.rc1.204.g551eb34607-goog
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)