linux-kernel - Re: [PATCH 0/7] rtc: Add support for limited alarm timer offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <571107fb-9b2d-425d-9201-25bae900341f@roeck-us.net>
Date:   Thu, 17 Aug 2023 15:36:05 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Benson Leung <bleung@...omium.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        John Stultz <jstultz@...gle.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH 0/7] rtc: Add support for limited alarm timer offsets

On Thu, Aug 17, 2023 at 09:51:17PM +0200, Alexandre Belloni wrote:
> On 16/08/2023 12:12:14-0700, Guenter Roeck wrote:
> > On Wed, Aug 16, 2023 at 06:14:35PM +0200, Alexandre Belloni wrote:
> > > On 16/08/2023 08:50:12-0700, Guenter Roeck wrote:
> > > > > I'm fine with the series, however, this doesn't solve the issue for RTCs
> > > > > that have an absolute limit on the alarm (as opposed to an offset to the
> > > > > current time/date).
> > > > > 
> > > > 
> > > > I thought that is checked by rtc_valid_range() in rtc_set_alarm().
> > > > Am I missing something ? Of course that assumes that the absolute
> > > > maximum alarm timeout matches range_max, but I didn't find any
> > > > drivers where that would not be the case.
> > > > 
> > > 
> > > There are RTCs where this is not the case. When this is far away in the
> > > future enough, the usual solution is to clip range_max which works but
> > > is not really great intellectually.
> > > 
> > Do you have an example, by any chance ?
> > 
> 
> I'm sorry, I've been looking and I couldn't find it anymore. Don't
> bother with this for now.
> 

I have been looking as well and did not find it either.
I'll go ahead and send v2 with the suggested changes.

Thanks,
Guenter