linux-kernel - Re: [PATCH v6 06/10] iommu/arm-smmu-v3: Move CD table to arm_smmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZN1uxPdV27xxK55Q@Asurada-Nvidia>
Date:   Wed, 16 Aug 2023 17:50:12 -0700
From:   Nicolin Chen <nicolinc@...dia.com>
To:     Michael Shavit <mshavit@...gle.com>
CC:     <iommu@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <robin.murphy@....com>,
        <will@...nel.org>, <jean-philippe@...aro.org>, <jgg@...dia.com>
Subject: Re: [PATCH v6 06/10] iommu/arm-smmu-v3: Move CD table to
 arm_smmu_master

On Wed, Aug 16, 2023 at 09:18:46PM +0800, Michael Shavit wrote:
 
> @@ -2463,16 +2448,43 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev)
>         if (smmu_domain->stage != ARM_SMMU_DOMAIN_BYPASS)
>                 master->ats_enabled = arm_smmu_ats_supported(master);
> 
> -       arm_smmu_install_ste_for_dev(master);
> 
>         spin_lock_irqsave(&smmu_domain->devices_lock, flags);

Nit: there'd be two empty lines in between; nicer to drop one.