linux-kernel - Re: [PATCH v6 2/6] perf test: Add a test for the new Arm CPU ID comparison behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fecfd732-df85-1bb9-f3d2-c1e12ca2db2e@arm.com>
Date:   Thu, 17 Aug 2023 10:02:08 +0100
From:   James Clark <james.clark@....com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     linux-perf-users@...r.kernel.org, irogers@...gle.com,
        john.g.garry@...cle.com, renyu.zj@...ux.alibaba.com,
        Will Deacon <will@...nel.org>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Haixin Yu <yuhaixin.yhx@...ux.alibaba.com>,
        Nick Forrington <nick.forrington@....com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Eduard Zingerman <eddyz87@...il.com>,
        Sohom Datta <sohomdatta1@...il.com>,
        Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 2/6] perf test: Add a test for the new Arm CPU ID
 comparison behavior



On 16/08/2023 17:11, Arnaldo Carvalho de Melo wrote:
> Em Wed, Aug 16, 2023 at 12:47:44PM +0100, James Clark escreveu:
>> +++ b/tools/perf/arch/arm64/tests/cpuid-match.c
>> @@ -0,0 +1,38 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +#include <linux/compiler.h>
>> +
>> +#include "arch-tests.h"
>> +#include "tests/tests.h"
>> +#include "util/header.h"
>> +
>> +int test__cpuid_match(struct test_suite *test __maybe_unused,
>> +			     int subtest __maybe_unused)
>> +{
>> +	/* midr with no leading zeros matches */
>> +	if (strcmp_cpuid_str("0x410fd0c0", "0x00000000410fd0c0"))
>> +		return -1;
>> +	/* Upper case matches */
>> +	if (strcmp_cpuid_str("0x410fd0c0", "0x00000000410FD0C0"))
>> +		return -1;
>> +	/* r0p0 = r0p0 matches */
>> +	if (strcmp_cpuid_str("0x00000000410fd480", "0x00000000410fd480"))
>> +		return -1;
>> +	/* r0p1 > r0p0 matches */
>> +	if (strcmp_cpuid_str("0x00000000410fd480", "0x00000000410fd481"))
>> +		return -1;
>> +	/* r1p0 > r0p0 matches*/
>> +	if (strcmp_cpuid_str("0x00000000410fd480", "0x00000000411fd480"))
>> +		return -1;
>> +	/* r0p0 < r0p1 doesn't match */
>> +	if (!strcmp_cpuid_str("0x00000000410fd481", "0x00000000410fd480"))
>> +		return -1;
>> +	/* r0p0 < r1p0 doesn't match */
>> +	if (!strcmp_cpuid_str("0x00000000411fd480", "0x00000000410fd480"))
>> +		return -1;
>> +	/* Different CPU doesn't match */
>> +	if (!strcmp_cpuid_str("0x00000000410fd4c0", "0x00000000430f0af0"))
>> +		return -1;
>> +
>> +	return 0;
>> +}
>> +
>> -- 
>> 2.34.1
>>
> ⬢[acme@...lbox perf-tools-next]$        git am ./v6_20230816_james_clark_perf_vendor_events_arm64_update_n2_and_v2_metrics_and_events_using_arm_telem.mbx
> Applying: perf test: Add a test for the new Arm CPU ID comparison behavior
> .git/rebase-apply/patch:93: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> ⬢[acme@...lbox perf-tools-next]$
> 
> I'm removing it

Interesting that checkpatch.pl doesn't see that. Thanks for the fix.