linux-kernel - Re: [PATCH] led: trig: timer: stop offloading on deactivation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230817091631.GH648357@google.com>
Date:   Thu, 17 Aug 2023 10:16:31 +0100
From:   Lee Jones <lee@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Daniel Golle <daniel@...rotopia.org>, Pavel Machek <pavel@....cz>,
        Johannes Berg <johannes.berg@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Richard Purdie <rpurdie@...ux.intel.com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        oe-kbuild-all@...ts.linux.dev,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH] led: trig: timer: stop offloading on deactivation

On Sat, 29 Jul 2023, kernel test robot wrote:

> Hi Daniel,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on lee-leds/for-leds-next]
> [also build test WARNING on wireless-next/main wireless/main linus/master pavel-leds/for-next v6.5-rc3 next-20230728]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Golle/led-trig-timer-stop-offloading-on-deactivation/20230728-203243
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
> patch link:    https://lore.kernel.org/r/728da6e11d34a39f717be07e246dcc4964b0fd51.1690542871.git.daniel%40makrotopia.org
> patch subject: [PATCH] led: trig: timer: stop offloading on deactivation
> config: mips-randconfig-r093-20230728 (https://download.01.org/0day-ci/archive/20230729/202307290641.SUCRTRMI-lkp@intel.com/config)
> compiler: mips-linux-gcc (GCC) 12.3.0
> reproduce: (https://download.01.org/0day-ci/archive/20230729/202307290641.SUCRTRMI-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202307290641.SUCRTRMI-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> drivers/leds/trigger/ledtrig-timer.c:129:47: sparse: sparse: Using plain integer as NULL pointer
>    drivers/leds/trigger/ledtrig-timer.c:129:50: sparse: sparse: Using plain integer as NULL pointer

Are you planning on fixing this?

> vim +129 drivers/leds/trigger/ledtrig-timer.c
> 
>    123	
>    124	static void timer_trig_deactivate(struct led_classdev *led_cdev)
>    125	{
>    126		/* Stop blinking */
>    127		led_set_brightness(led_cdev, LED_OFF);
>    128		if (led_cdev->blink_set)
>  > 129			led_cdev->blink_set(led_cdev, 0, 0);
>    130	}
>    131	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

-- 
Lee Jones [李琼斯]