linux-kernel - Re: [PATCH] driver core: shut down devices asynchronously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Aug 2023 08:10:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Stuart Hayes <stuart.w.hayes@...il.com>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Tanjore Suresh <tansuresh@...gle.com>,
        Martin Belanger <Martin.Belanger@...l.com>,
        Oliver O'Halloran <oohall@...il.com>,
        Daniel Wagner <dwagner@...e.de>,
        Keith Busch <kbusch@...nel.org>, Lukas Wunner <lukas@...ner.de>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Stuart Hayes <stuart.w.hayes@...il.com>
Subject: Re: [PATCH] driver core: shut down devices asynchronously

Hi Stuart,

kernel test robot noticed the following build warnings:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on driver-core/driver-core-next driver-core/driver-core-linus linus/master v6.5-rc6 next-20230816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Stuart-Hayes/driver-core-shut-down-devices-asynchronously/20230816-234737
base:   driver-core/driver-core-testing
patch link:    https://lore.kernel.org/r/20230816154518.3487-1-stuart.w.hayes%40gmail.com
patch subject: [PATCH] driver core: shut down devices asynchronously
config: i386-defconfig (https://download.01.org/0day-ci/archive/20230817/202308170710.K525oxZ5-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308170710.K525oxZ5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308170710.K525oxZ5-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/base/core.c:4762:6: warning: no previous declaration for 'shutdown_dev_work' [-Wmissing-declarations]
    void shutdown_dev_work(struct work_struct *work)
         ^~~~~~~~~~~~~~~~~


vim +/shutdown_dev_work +4762 drivers/base/core.c

  4761	
> 4762	void shutdown_dev_work(struct work_struct *work)
  4763	{
  4764		struct shutdown_work *sd_work = container_of(work, struct shutdown_work, work);
  4765		struct shutdown_work *child_sd_work;
  4766		struct device *dev = sd_work->dev;
  4767	
  4768		/*
  4769		 * wait for child devices to finish shutdown
  4770		 */
  4771		list_for_each_entry(child_sd_work, &sd_work->children, node) {
  4772			wait_for_completion(&child_sd_work->complete);
  4773		}
  4774	
  4775		if (dev) {
  4776			/*
  4777			 * Make sure the device is off the kset list, in the
  4778			 * event that dev->*->shutdown() doesn't remove it.
  4779			 */
  4780			spin_lock(&devices_kset->list_lock);
  4781			list_del_init(&dev->kobj.entry);
  4782			spin_unlock(&devices_kset->list_lock);
  4783	
  4784			shutdown_device(dev, dev->parent);
  4785		}
  4786	
  4787		complete(&sd_work->complete);
  4788	}
  4789	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki