[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0a50f81d-ffc2-9a24-9798-424f353d209e@163.com>
Date: Thu, 17 Aug 2023 09:21:07 +0800
From: "xingtong.wu" <xingtong_wu@....com>
To: Ashok Raj <ashok_raj@...ux.intel.com>
Cc: ilpo.jarvinen@...ux.intel.com, hdegoede@...hat.com,
markgross@...nel.org, xingtong.wu@...mens.com,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
gerd.haeussler.ext@...mens.com, tobias.schaffner@...mens.com,
lkp@...el.com, Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH v2 2/2] platform/x86/siemens: simatic-ipc-batt: fix logic
error for BX-59A
On 2023/8/16 23:45, Ashok Raj wrote:
> On Sat, Aug 01, 2043 at 01:34:17AM +0800, xingtong_wu@....com wrote:
> ^^^^^^^^^^^^^^^^^^^^
>
> Nice way to keep your mail on top of the sort :-).. You need to fixup your
> system date.
I'm sorry that there are time problem on my local machine which lead to a
wrong time in email, but I just sent an email to remind hdegoede@...hat.com
individually, the time problem was solved by him on his branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=review-hans&id=b01c1e022f7f0c327ecc7544dc44d5f80a2d2bd9
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=review-hans&id=7abf253afa5c72c0c7eb21f67da1d443f036737a
>
>> From: "xingtong.wu" <xingtong.wu@...mens.com>
>>
>> The variable "priv.devmode" is missing from if statement that leads
>> to a logical error. Add the missing variable to the if condition.
>>
>> Fixes: c56beff20375 ("platform/x86/siemens: simatic-ipc-batt: add support for module BX-59A")
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202308010001.BGYCSQrl-lkp@intel.com/
>>
>> Signed-off-by: xingtong.wu <xingtong.wu@...mens.com>
>> ---
>> drivers/platform/x86/siemens/simatic-ipc-batt.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt.c b/drivers/platform/x86/siemens/simatic-ipc-batt.c
>> index d66b9969234b..e6c12c52843c 100644
>> --- a/drivers/platform/x86/siemens/simatic-ipc-batt.c
>> +++ b/drivers/platform/x86/siemens/simatic-ipc-batt.c
>> @@ -194,7 +194,8 @@ int simatic_ipc_batt_probe(struct platform_device *pdev, struct gpiod_lookup_tab
>>
>> if (table->table[2].key) {
>> flags = GPIOD_OUT_HIGH;
>> - if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A || SIMATIC_IPC_DEVICE_BX_59A)
>> + if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A ||
>> + priv.devmode == SIMATIC_IPC_DEVICE_BX_59A)
>> flags = GPIOD_OUT_LOW;
>> priv.gpios[2] = devm_gpiod_get_index(dev, "CMOSBattery meter", 2, flags);
>> if (IS_ERR(priv.gpios[2])) {
>> --
>> 2.25.1
>>
Powered by blists - more mailing lists