linux-kernel - Re: [PATCH v6 4/6] perf jevents: Add a new expression builtin strcmp_cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41140a38-b885-c198-d198-4e9a47de19d7@oracle.com>
Date:   Thu, 17 Aug 2023 10:53:41 +0100
From:   John Garry <john.g.garry@...cle.com>
To:     James Clark <james.clark@....com>,
        linux-perf-users@...r.kernel.org, irogers@...gle.com,
        renyu.zj@...ux.alibaba.com, acme@...nel.org
Cc:     Will Deacon <will@...nel.org>, Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Haixin Yu <yuhaixin.yhx@...ux.alibaba.com>,
        Nick Forrington <nick.forrington@....com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Eduard Zingerman <eddyz87@...il.com>,
        Sohom Datta <sohomdatta1@...il.com>,
        Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 4/6] perf jevents: Add a new expression builtin
 strcmp_cpuid_str()

On 16/08/2023 12:47, James Clark wrote:
> This will allow writing formulas that are conditional on a specific
> CPU type or CPU version. It calls through to the existing
> strcmp_cpuid_str() function in Perf which has a default weak version,
> and an arch specific version for x86 and arm64.
> 
> The function takes an 'ID' type value, which is a string. But in this
> case Arm CPU IDs are hex numbers prefixed with '0x'. metric.py
> assumes strings are only used by event names, and that they can't start
> with a number ('0'), so an additional change has to be made to the
> regex to convert hex numbers back to 'ID' types.
> 
> Signed-off-by: James Clark<james.clark@....com>

Reviewed-by: John Garry <john.g.garry@...cle.com>