linux-kernel - Re: [PATCH 20/20] ARC: pt_regs: create seperate type for ecr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230817120935.59181-1-kozlov@synopsys.com>
Date:   Thu, 17 Aug 2023 16:09:35 +0400
From:   Pavel.Kozlov@...opsys.com
To:     Vineet Gupta <vgupta@...nel.org>,
        linux-snps-arc@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org,
        Shahab Vahedi <Shahab.Vahedi@...opsys.com>,
        Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Subject: Re: [PATCH 20/20] ARC: pt_regs: create seperate type for ecr

Hi Vineet,

I'm testing your updates and ran into the same build issue reported by the build 
robot.
http://lists.infradead.org/pipermail/linux-snps-arc/2023-August/007522.html

> #ifdef CONFIG_ISA_ARCOMPACT
> @@ -40,18 +51,7 @@ struct pt_regs {
>           *        Last word used by Linux for extra state mgmt (syscall-restart)
>           * For interrupts, use artificial ECR values to note current prio-level
>           */
> -       union {
> -               struct {
> -#ifdef CONFIG_CPU_BIG_ENDIAN
> -                       unsigned long state:8, ecr_vec:8,
> -                                     ecr_cause:8, ecr_param:8;
> -#else
> -                       unsigned long ecr_param:8, ecr_cause:8,
> -                                     ecr_vec:8, state:8;
> -#endif
> -               };
> -               unsigned long event;
> -       };
> +       ecr_reg ecr;
> }
>
> #define MAX_REG_OFFSET offsetof(struct pt_regs, event)

This change causes a build issue for ARC700, as the event field has been
removed and the MAX_REG_OFFSET macro hasn't been updated.

Regards,
Pavel