[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <6db95796-385e-48ef-a32f-a5fba63b4678@app.fastmail.com>
Date: Thu, 17 Aug 2023 14:42:57 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Christophe Leroy" <christophe.leroy@...roup.eu>,
"Michael Ellerman" <mpe@...erman.id.au>,
"Nicholas Piggin" <npiggin@...il.com>
Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc/4xx: Remove WatchdogHandler() to fix no previous prototype
error
On Thu, Aug 17, 2023, at 14:40, Christophe Leroy wrote:
> Building ppc40x_defconfig throws the following error:
>
> CC arch/powerpc/kernel/traps.o
> arch/powerpc/kernel/traps.c:2232:29: warning: no previous prototype for
> 'WatchdogHandler' [-Wmissing-prototypes]
> 2232 | void __attribute__ ((weak)) WatchdogHandler(struct pt_regs
> *regs)
> | ^~~~~~~~~~~~~~~
>
> This function was imported by commit 14cf11af6cf6 ("powerpc: Merge
> enough to start building in arch/powerpc.") as a weak function but
> never defined and/or called outside traps.c
>
> As it has only one caller fold it inside its caller and remove it.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Arnd Bergmann <arnd@...db.de>
Powered by blists - more mailing lists