linux-kernel - Re: [PATCH] xhci: Disable connect, disconnect and over-current wakeup on system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAd53p67m3o1nz3cKjiSJWDMWnsoB-4=pFWwBhpaoZ+ns22-tw@mail.gmail.com>
Date:   Thu, 17 Aug 2023 21:13:55 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:     Oliver Neukum <oneukum@...e.com>, mathias.nyman@...el.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci: Disable connect, disconnect and over-current wakeup
 on system suspend

On Thu, Aug 17, 2023 at 8:52 PM Mathias Nyman
<mathias.nyman@...ux.intel.com> wrote:
>
> On 17.8.2023 14.18, Oliver Neukum wrote:
> > On 17.08.23 11:33, Kai-Heng Feng wrote:
> >
> > Hi,
> >
> >> So for system-wide suspend, also disable connect, disconnect and
> >> over-current wakeup to prevent spurious wakeup.
> >
> > isn't this breaking the ability to effectively use your root hub
> > as a source of system wakeups? That is, even if you want the
> > system to wake up if somebody attaches a new device, it no longer works?
> >
>
> I got the same concern about this.

Per my test, it doesn't work with or without this change. This applies
to disconnection too, disconnecting USB devices doesn't wake the
system up.
Furthermore, if the newly attached device is a USB keyboard, pressing
it doesn't wake the system up either. Probably because remote wakeup
isn't configured when the system is suspended.

Kai-Heng

>
> -Mathias