linux-kernel - Re: [PATCH v1 1/1] fs/affs: Rename local toupper() to fn() to avoid confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230817134618.GT2420@suse.cz>
Date:   Thu, 17 Aug 2023 15:46:18 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Christian Brauner <brauner@...nel.org>,
        Dave Chinner <dchinner@...hat.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        David Sterba <dsterba@...e.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v1 1/1] fs/affs: Rename local toupper() to fn() to avoid
 confusion

On Thu, Aug 17, 2023 at 03:12:17PM +0300, Andy Shevchenko wrote:
> A compiler may see the collision with the toupper() defined in ctype.h:
> 
>  fs/affs/namei.c:159:19: warning: unused variable 'toupper' [-Wunused-variable]
>    159 |         toupper_t toupper = affs_get_toupper(sb);
> 
> To prevent this from happening, rename toupper local variable to fn.
> 
> Initially this had been introduced by 24579a881513 ("v2.4.3.5 -> v2.4.3.6")
> in the history.git by history group.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Added to affs tree, thanks.