linux-kernel - Re: [PATCH v4] hid-mcp2200: added driver for GPIOs of MCP2200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a04507b2-f732-65cb-d69a-9da0400d3a4d@infradead.org>
Date:   Thu, 17 Aug 2023 07:42:05 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     johannes@...-linux.rocks, jikos@...nel.org
Cc:     benjamin.tissoires@...hat.com, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org, andi.shyti@...nel.org,
        christophe.jaillet@...adoo.fr, ak@...klinger.de
Subject: Re: [PATCH v4] hid-mcp2200: added driver for GPIOs of MCP2200

Hi--

On 8/17/23 02:15, johannes@...-linux.rocks wrote:
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index e11c1c803676..791cc5c8fa0d 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -1301,6 +1301,16 @@ config HID_MCP2221
>  	To compile this driver as a module, choose M here: the module
>  	will be called hid-mcp2221.ko.
>  
> +config HID_MCP2200
> +   tristate "Microchip MCP2200 HID USB-to-GPIO bridge"
> +   depends on USB_HID
> +   imply GPIOLIB
> +   help
> +   Provides GPIO functionality over USB-HID through MCP2200 device.
> +
> +   To compile this driver as a module, choose M here: the module
> +   will be called hid-mcp2200.ko.
> +

Please follow coding-style.rst for Kconfig files, copied here with
an example:

10) Kconfig configuration files
-------------------------------

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.  Example::

  config AUDIT
	bool "Auditing support"
	depends on NET
	help
	  Enable auditing infrastructure that can be used with another
	  kernel subsystem, such as SELinux (which requires this for
	  logging of avc messages output).  Does not do system-call
	  auditing without CONFIG_AUDITSYSCALL.


>  config HID_KUNIT_TEST
>  	tristate "KUnit tests for HID" if !KUNIT_ALL_TESTS
>  	depends on KUNIT

thanks.
-- 
~Randy