linux-kernel - Re: [PATCH v6 6/6] perf vendor events arm64: Update N2 and V2 metrics and events using Arm telemetry repo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Aug 2023 15:41:11 +0100
From:   James Clark <james.clark@....com>
To:     John Garry <john.g.garry@...cle.com>
Cc:     Will Deacon <will@...nel.org>, Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Haixin Yu <yuhaixin.yhx@...ux.alibaba.com>,
        Nick Forrington <nick.forrington@....com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Eduard Zingerman <eddyz87@...il.com>,
        Sohom Datta <sohomdatta1@...il.com>,
        Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-perf-users@...r.kernel.org, irogers@...gle.com,
        renyu.zj@...ux.alibaba.com, acme@...nel.org
Subject: Re: [PATCH v6 6/6] perf vendor events arm64: Update N2 and V2 metrics
 and events using Arm telemetry repo



On 17/08/2023 12:09, John Garry wrote:
> On 16/08/2023 12:47, James Clark wrote:
>> Apart from some slight naming and grouping differences, the new metrics
>> are functionally the same as the existing ones. Any missing metrics were
>> manually appended to the end of the auto generated file.
>>
>> For the events, the new data includes descriptions that may have product
>> specific details and new groupings that will be consistent with other
>> products.
>>
>> After generating the metrics from the telemetry repo [1], the following
>> manual steps were performed:
>>
>>   * Change the topdown expressions to compare on CPUID and use
>>     #slots so that the same data can be shared between N2 and V2. Apart
>>     from these modifications, the expressions now match more closely with
>>     the Arm telemetry data which will hopefully make future updates
>>     easier.
>>
>>   * Append some metrics from the old N2/V2 data that aren't present in
>>     the telemetry data. These will possibly be added to the
>>     telemetry-solution repo at a later time:
>>
>>      l3d_cache_mpki, l3d_cache_miss_rate, branch_pki, ipc_rate, spec_ipc,
>>      retired_rate, wasted_rate, branch_immed_spec_rate,
>>      branch_return_spec_rate, branch_indirect_spec_rate
>>
>> [1]:https://urldefense.com/v3/__https://gitlab.arm.com/telemetry-solution/telemetry-solution/-/blob/main/data/pmu/cpu/neoverse/neoverse-n2.json__;!!ACWV5N9M2RV99hQ!NW7DYe7T69u8RFn9WLyiCcoHm-8BtlxNK3PRw19udocwlwv0vQpjcSDT5XqGbWzvPQyFrG-eRkuu_VZt7cO8-Q$ 
>> Signed-off-by: James Clark<james.clark@....com>
> 
> Reviewed-by: John Garry <john.g.garry@...cle.com>

Thanks for the reviews!