lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <64de3767e1245_29e22029456@dwillia2-xfh.jf.intel.com.notmuch>
Date:   Thu, 17 Aug 2023 08:06:15 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
        <dan.j.williams@...el.com>
CC:     <vishal.l.verma@...el.com>, <dave.jiang@...el.com>,
        <ira.weiny@...el.com>, <nvdimm@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>, <yusongping@...wei.com>,
        <artem.kuzin@...wei.com>, <kjain@...ux.ibm.com>, <maddy@...ibm.com>
Subject: RE: [PATCH] drivers: nvdimm: fix memleak

[ add Kajol and Madhavan ]

Konstantin Meskhidze wrote:
> Memory pointed by 'nd_pmu->pmu.attr_groups' is allocated in function
> 'register_nvdimm_pmu' and is lost after 'kfree(nd_pmu)' call in function
> 'unregister_nvdimm_pmu'.

Yes, looks like a real issue, but also completely avoidable by using statically
defined groups.

My fault for not catching this earlier, but Kajol, why is nd_perf not using
statically defined sysfs attribute groups?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ