linux-kernel - Re: [GIT PULL] one more nfsd fix for 6.5-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=whqj8mRjZWCriZnbUyvtnNwwUJE1Zbg8eandWjk059rkw@mail.gmail.com>
Date:   Thu, 17 Aug 2023 16:59:08 +0200
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Chuck Lever III <chuck.lever@...cle.com>
Cc:     Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Jeff Layton <jlayton@...nel.org>
Subject: Re: [GIT PULL] one more nfsd fix for 6.5-rc

On Thu, 17 Aug 2023 at 16:55, Chuck Lever III <chuck.lever@...cle.com> wrote:
> > On Aug 17, 2023, at 10:49 AM, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> >
> > I'm sure it's right, but it really smells odd to set that initial
> > offset not when the bvec is created, but long afterwards, just before
> > it is used.
> >
> > Is there some reason why 'bv_offset' isn't initialized when the bvec is created?
>
> Yes:
>
> https://lore.kernel.org/linux-nfs/7c9421cc4b92dee76cc7560c50a4a0ab3fb1ef0d.camel@kernel.org/T/#t

Ugh, how ugly.

> But also note that this fix will get replaced in v6.6
>
> I just wanted to ensure that v6.5 wasn't broken. It's a little late in the
> cycle to apply 383bc8bbc.

Sounds good to me. Thanks for the explanation.

              Linus