linux-kernel - Re: [PATCH V2 0/2] riscv: stack: Fixup independent softirq/irq stack for CONFIG_FRAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169228562466.20811.13415270526946490389.git-patchwork-notify@kernel.org>
Date:   Thu, 17 Aug 2023 15:20:24 +0000
From:   patchwork-bot+linux-riscv@...nel.org
To:     Guo Ren <guoren@...nel.org>
Cc:     linux-riscv@...ts.infradead.org, palmer@...osinc.com,
        paul.walmsley@...ive.com, falcon@...ylab.org, bjorn@...nel.org,
        conor.dooley@...rochip.com, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        guoren@...ux.alibaba.com
Subject: Re: [PATCH V2 0/2] riscv: stack: Fixup independent softirq/irq stack for
 CONFIG_FRAME_POINTER=n

Hello:

This series was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <palmer@...osinc.com>:

On Sat, 15 Jul 2023 20:15:04 -0400 you wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> The independent softirq/irq stack uses s0 to save & restore sp, but s0
> would be corrupted when CONFIG_FRAME_POINTER=n. So add s0 in the clobber
> list to fix the problem.
> 
> <+0>:     addi    sp,sp,-32
> <+2>:     sd      s0,16(sp)
> <+4>:     sd      s1,8(sp)
> <+6>:     sd      ra,24(sp)
> <+8>:     sd      s2,0(sp)
> <+10>:    mv      s0,a0		--> compiler allocate s0 for a0 when CONFIG_FRAME_POINTER=n
> <+12>:    jal     ra,0xffffffff800bc0ce <irqentry_enter>
> <+16>:    ld      a5,56(tp) # 0x38
> <+20>:    lui     a4,0x4
> <+22>:    mv      s1,a0
> <+24>:    xor     a5,a5,sp
> <+28>:    bgeu    a5,a4,0xffffffff800bc092 <do_irq+88>
> <+32>:    auipc   s2,0x5d
> <+36>:    ld      s2,1118(s2) # 0xffffffff801194b8 <irq_stack_ptr>
> <+40>:    add     s2,s2,a4
> <+42>:    addi    sp,sp,-8
> <+44>:    sd      ra,0(sp)
> <+46>:    addi    sp,sp,-8
> <+48>:    sd      s0,0(sp)
> <+50>:    addi    s0,sp,16	--> our code clobber the s0
> <+52>:    mv      sp,s2
> <+54>:    mv      a0,s0		--> a0 got wrong value for handle_riscv_irq
> <+56>:    jal     ra,0xffffffff800bbb3a <handle_riscv_irq>
> 
> [...]

Here is the summary with links:
  - [V2,1/2] riscv: stack: Fixup independent irq stack for CONFIG_FRAME_POINTER=n
    https://git.kernel.org/riscv/c/8d0be64154cf
  - [V2,2/2] riscv: stack: Fixup independent softirq stack for CONFIG_FRAME_POINTER=n
    https://git.kernel.org/riscv/c/ebc9cb03b21e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html