linux-kernel - Re: [PATCH v6] mm/filemap: remove hugetlb special casing in filemap.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230818183407.GA5850@monkey>
Date:   Fri, 18 Aug 2023 11:34:07 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Sidhartha Kumar <sidhartha.kumar@...cle.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        songmuchun@...edance.com
Subject: Re: [PATCH v6] mm/filemap: remove hugetlb special casing in filemap.c

On 08/18/23 19:09, Matthew Wilcox wrote:
> 
> There's also a conceptual reduction in complexity.  We no longer need to
> think about whether the inode is hugetlb or not before doing the lookup
> and scaling the byte offset differently.

I 'think' this was the primary motivation for this patch.

Recent discussions about HGM always came back to hugetlb special case code
in the core mm.  HGM would add a little more, and most people thought there
was too much already.  Most everyone in those discussions agreed there
should be some effort to unify hugetlb and core mm code as much as possible
to reduce these special cases.  This is one step in that direction.

As a hugetlb maintainer, I don't like any decrease in performance even
if it is not readily observable.  However, as a member of the mm community
I like the fact that there is less special case hugetlb code.  Overall,
I consider this a win.
-- 
Mike Kravetz