linux-kernel - Re: [PATCH v2] serial: 8250_bcm7271: improve bcm7271 8250 port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7332fd46-0310-8fdd-81a6-4ac722a6eda4@broadcom.com>
Date:   Fri, 18 Aug 2023 12:22:25 -0700
From:   Justin Chen <justin.chen@...adcom.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org, Al Cooper <alcooperx@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Ogness <john.ogness@...utronix.de>,
        Jiaqing Zhao <jiaqing.zhao@...ux.intel.com>,
        "open list:TTY LAYER" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] serial: 8250_bcm7271: improve bcm7271 8250 port



On 8/18/23 3:59 AM, Andy Shevchenko wrote:
> On Thu, Aug 17, 2023 at 02:13:18PM -0700, Justin Chen wrote:
>> The 8250 BCM7271 UART is not a direct match to PORT_16550A and other
>> generic ports do not match its hardware capabilities. PORT_ALTR matches
>> the rx trigger levels, but its vendor configurations are not compatible.
>> Unfortunately this means we need to create another port to fully capture
>> the hardware capabilities of the BCM7271 UART.
>>
>> To alleviate some latency pressures, we default the rx trigger level to 8.
> 
> ...
> 
>> +		.flags		= UART_CAP_FIFO | UART_CAP_AFE
> 
> Leave trailing comma
> 

Acked

> ...
> 
>> +/* Broadcom BCM7271 UART */
>> +#define PORT_BCM7271    76
> 
> 13 is free why not using it?
> 

I was looking for a number close to another Broadcom port. I was 
prioritizing locality. But I have no issues with 13, I will change in v3.

Thanks,
Justin



Download attachment "smime.p7s" of type "application/pkcs7-signature" (4206 bytes)