[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20230818030239.39524-1-xiaoshoukui@gmail.com>
Date: Thu, 17 Aug 2023 23:02:39 -0400
From: xiaoshoukui <xiaoshoukui@...il.com>
To: dsterba@...e.cz
Cc: clm@...com, dsterba@...e.com, josef@...icpanda.com,
linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
xiaoshoukui@...il.com, xiaoshoukui@...jie.com.cn
Subject: Re: [PATCH] btrfs: fix BUG_ON condition in btrfs_cancel_balance
> Seems that it's from times the balance was not cancellable the same way
> as now. Also it's a good time to switch the BUG_ON to an assertion or
> handle it properly.
That's the point. Canceling the balance only takes into account the normal scenarios.
Replacing the BUG ON here with an assertion would make the code cleaner.
> I'll change to to ASSERT, this is really to verify that the state
> tracking works properly.
The ASSERT and BUG ON macros have already helped us uncover many hidden issues.
Powered by blists - more mailing lists