linux-kernel - Re: [PATCH] tracefs: avoid setting i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230817200044.373f9655@gandalf.local.home>
Date:   Thu, 17 Aug 2023 20:00:44 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Sishuai Gong <sishuai.system@...il.com>
Cc:     mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] tracefs: avoid setting i_mode to a temp value

On Thu, 17 Aug 2023 19:47:34 -0400
Sishuai Gong <sishuai.system@...il.com> wrote:

> > Can you produce this race?  
> This data race was detected when I was testing the kernel (e.g., fuzzing)
> but I did not make the attempt to reproduce it.

Now, I'm curious to what exactly is this fixing? The intermediate value is
the S_IALLUGO bits cleared. Doesn't that mean that nothing has permission?

It's not a big deal if that's the case, as it just means things are locked
down a bit more than normal.

My question is, do we really care, and why should we?

-- Steve