linux-kernel - Re: [PATCH v2] ext4: mballoc: avoid garbage value from err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169233503392.3504102.15591922902240482750.b4-ty@mit.edu>
Date:   Fri, 18 Aug 2023 01:05:11 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     adilger.kernel@...ger.ca, nathan@...nel.org,
        ndesaulniers@...gle.com, trix@...hat.com,
        Su Hui <suhui@...china.com>
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] ext4: mballoc: avoid garbage value from err


On Tue, 25 Jul 2023 12:33:11 +0800, Su Hui wrote:
> clang's static analysis warning: fs/ext4/mballoc.c
> line 4178, column 6, Branch condition evaluates to a garbage value.
> 
> err is uninitialized and will be judged when 'len <= 0' or
> it first enters the loop while the condition "!ext4_sb_block_valid()"
> is true. Although this can't make problems now, it's better to
> correct it.
> 
> [...]

Applied, thanks!

[1/1] ext4: mballoc: avoid garbage value from err
      commit: f2060a35e10fc3db2950e98f5b7f6f55ad4e4079

Best regards,
-- 
Theodore Ts'o <tytso@....edu>