[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZN8BipaGe6DOwiVS@gondor.apana.org.au>
Date: Fri, 18 Aug 2023 13:28:42 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Lucas Segarra Fernandez <lucas.segarra.fernandez@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
qat-linux@...el.com, andriy.shevchenko@...el.com,
alx.manpages@...il.com,
Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH 4/4] crypto: qat - add pm_status debugfs file
On Thu, Aug 17, 2023 at 04:33:17PM +0200, Lucas Segarra Fernandez wrote:
>
> +static struct pm_status_row pm_event_rows[] = {
> + PM_INFO_REGSET_ENTRY32(event_log[0], EVENT0),
> + PM_INFO_REGSET_ENTRY32(event_log[1], EVENT1),
> + PM_INFO_REGSET_ENTRY32(event_log[2], EVENT2),
> + PM_INFO_REGSET_ENTRY32(event_log[3], EVENT3),
> + PM_INFO_REGSET_ENTRY32(event_log[4], EVENT4),
> + PM_INFO_REGSET_ENTRY32(event_log[5], EVENT5),
> + PM_INFO_REGSET_ENTRY32(event_log[6], EVENT6),
> + PM_INFO_REGSET_ENTRY32(event_log[7], EVENT7),
> +};
> +
> +static_assert(ARRAY_SIZE_OF_FIELD(struct icp_qat_fw_init_admin_pm_info, event_log) ==
> + ARRAY_SIZE(pm_event_rows));
Was all of that churn just for this one line?
How about simply declaring a macro
#define QAT_NUMBER_OF_PM_EVENTS 8
and then use it for the two arrays:
static struct pm_status_row pm_event_rows[QAT_NUMBER_OF_PM_EVENTS] = {
__u32 event_log[QAT_NUMBER_OF_PM_EVENTS];
What am I missing?
Cheers,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists